Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/datetime #688

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Fix/datetime #688

wants to merge 2 commits into from

Conversation

jwaspin
Copy link
Contributor

@jwaspin jwaspin commented Jul 2, 2024

v1.5.0-beta.28
Fixes issues when selecting precision for dates.

https://dev.mdeditor.org/

@jwaspin jwaspin requested a review from hmaier-fws July 2, 2024 16:29
@hmaier-fws
Copy link
Contributor

@jwaspin The precision values display properly on import, however there is an unexpected behavior that results in the date precision of a record, in active edit mode, being applied to records that are subsequently edited.

Steps to recreate

  1. Import test records from: https://raw.githubusercontent.com/adiwg/mdjson-examples/master/date-time/dateTest-mdeditor-20240702.json
  2. Edit first record ("Date test YMD-HMS") and observe the "Time Period Start Date" (= "2024-07-02T08:25:04-08:00").
  3. Select record name in left sidebar to exit edit mode.
  4. Edit last record ("Date test YYYY") and observe "Time Period Start Date" (= "2024").
  5. Select the edit icon to edit the first record ("Date test YMD-HMS"). Do not first exit edit mode as above.

Observed behavior

  • The "Time Period Start Date" for record "Date test YMD-HMS" has changed from its initial value ("2024-07-02T08:25:04-08:00") to the precision of the record that was previously in edit mode.
  • The edit icon turns red indicating a change.
  • Selecting "Cancel" does not revert the date to the initial precision.

Expected behavior:
Record date-time precision does not change unless the user selects a value from the Date "Precision" picklist.

@hmaier-fws hmaier-fws marked this pull request as draft July 3, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants